coolaj86/le-sni-auto.js
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

noop on async getCertificates error #2

Merged
coolaj86 merged 1 commits from :master into master 2019-04-15 17:36:25 +00:00
Conversation 5 Commits 1 Files Changed 1 +4 -1
Ghost commented 2019-01-30 04:10:00 +00:00
First-time contributor
Copy Link

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.
coolaj86 commented 2019-01-31 15:04:18 +00:00
Owner
Copy Link

Thanks! I’ll merge this in today.

What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?

Thanks! I’ll merge this in today. What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?
Ghost commented 2019-01-31 21:00:13 +00:00
Author
First-time contributor
Copy Link

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.
Ghost commented 2019-04-15 04:52:16 +00:00
Author
First-time contributor
Copy Link

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.
coolaj86 commented 2019-04-15 16:36:06 +00:00
Owner
Copy Link

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.
coolaj86 closed this pull request 2019-04-15 17:36:25 +00:00
coolaj86 commented 2019-04-15 17:38:35 +00:00
Owner
Copy Link

Published le-sni-auto@2.1.9

Published le-sni-auto@2.1.9
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/le-sni-auto.js#2
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?